Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move internal apps API types out of extensions package #70028

Merged
merged 9 commits into from Oct 26, 2018
Merged

move internal apps API types out of extensions package #70028

merged 9 commits into from Oct 26, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 19, 2018 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
related to #43214

Special notes for your reviewer:

  • removes unused CustomMetricTarget types
  • moves internal API types, fuzzing, validation, and conversion from extensions to apps
  • stops generating GetScale/UpdateScale for internal clients (since it doesn't work correctly)

The main commits that need review:

  • Change registration and custom conversion from extensions to apps
  • fixup extensions->apps references

The "move ..." commits are pure moves, no internal changes.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2018
@liggitt liggitt force-pushed the move-extensions-types branch 2 times, most recently from b63cd06 to e84f7e8 Compare October 19, 2018 17:57
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2018
@liggitt liggitt changed the title WIP - move extensions types out move internal API types out of extensions package Oct 19, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2018
@liggitt liggitt changed the title move internal API types out of extensions package move internal apps API types out of extensions package Oct 19, 2018
@soltysh soltysh mentioned this pull request Oct 19, 2018
Closed
41 tasks
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 19, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 19, 2018

/assign @kow3ns
@kubernetes/sig-apps-pr-reviews

soltysh
soltysh approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@jennybuckley
Copy link

/assign @caesarxuchao

caesarxuchao
caesarxuchao reviewed Oct 26, 2018
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Fix the nits if you have to rebase anyway.

pkg/api/testing/serialization_test.go Outdated
@@ -101,7 +101,7 @@ func TestSetControllerConversion(t *testing.T) {
},
}

t.Logf("rs._internal.extensions -> rs.v1beta1.extensions")
t.Logf("rs._internal.apps -> rs.v1beta1.apps")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/v1beta1.apps/v1.apps

pkg/api/testing/serialization_test.go Outdated
@@ -116,7 +116,7 @@ func TestSetControllerConversion(t *testing.T) {
),
)

t.Logf("rs.v1beta1.extensions -> rc._internal")
t.Logf("rs.v1beta1.apps -> rc._internal")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same nit

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 26, 2018

nits fixed, retagging

need /approve from @caesarxuchao for replication controller package and @timothysc for kubeadm package

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 26, 2018 •
edited

/assign @timothysc

transitive dependency changed from extensions to apps, updated cmd/kubeadm/.import-restrictions

@timothysc timothysc removed their assignment Oct 26, 2018
@timothysc
Copy link
Member

/approve

from the kubeadm side.

@caesarxuchao
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, liggitt, soltysh, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1df4f8e into kubernetes:master Oct 26, 2018
@liggitt liggitt deleted the move-extensions-types branch October 29, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

@caesarxuchao caesarxuchao

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@liggitt @neolit123 @timothysc @dims @jennybuckley @k8s-ci-robot @caesarxuchao @fejta-bot @soltysh @kow3ns